Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust/drivers/datafusion): add support for bulk ingest #2279

Merged
merged 5 commits into from
Nov 5, 2024
Merged

feat(rust/drivers/datafusion): add support for bulk ingest #2279

merged 5 commits into from
Nov 5, 2024

Conversation

tokoko
Copy link
Contributor

@tokoko tokoko commented Oct 27, 2024

  • swaps todos from Optionable impls to partial support: none for Database, CurrentCatalog and CurrentSchema for Connection and IngestTableTarget for Statement.
  • adds support for binding a single batch and executing a bulk insert on it. I used RefCell to pass bound record batch from bind to an execute_update method.

@github-actions github-actions bot added this to the ADBC Libraries 15 milestone Oct 27, 2024
@tokoko
Copy link
Contributor Author

tokoko commented Oct 28, 2024

@mbrobbel please TAL when you will find some time, thanks

mbrobbel
mbrobbel reviewed Nov 4, 2024
View reviewed changes
rust/drivers/datafusion/src/lib.rs Outdated Show resolved Hide resolved
rust/drivers/datafusion/src/lib.rs Outdated Show resolved Hide resolved
rust/drivers/datafusion/src/lib.rs Outdated Show resolved Hide resolved
rust/drivers/datafusion/src/lib.rs Outdated Show resolved Hide resolved
rust/drivers/datafusion/src/lib.rs Outdated Show resolved Hide resolved
rust/drivers/datafusion/src/lib.rs Outdated Show resolved Hide resolved
@lidavidm lidavidm merged commit d07b9f0 into apache:main Nov 5, 2024
29 checks passed
@tokoko tokoko deleted the datafusion-options branch November 5, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrobbel mbrobbel mbrobbel approved these changes

@lidavidm lidavidm lidavidm approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 15
Development

Successfully merging this pull request may close these issues.
3 participants
@tokoko @lidavidm @mbrobbel